Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error handling in update stream #4705

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 26, 2023

Description

Handle fatal errors in update stream, by sending an not found update with issues.

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Apr 26, 2023 2:14pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-cra-web ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-native-web ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 26, 2023 2:14pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2023 2:14pm

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

🟢 CI successful 🟢

Thanks

@sokra sokra marked this pull request as ready for review April 26, 2023 09:20
@sokra sokra requested a review from a team as a code owner April 26, 2023 09:20
@sokra sokra enabled auto-merge (squash) April 26, 2023 14:13
@sokra sokra merged commit c0565d4 into main Apr 26, 2023
@sokra sokra deleted the sokra/import-error-handling branch April 26, 2023 14:27
sokra added a commit to vercel/next.js that referenced this pull request Apr 26, 2023
### What?

* vercel/turborepo#4700 <!-- Tobias Koppers - update
deps -->
* vercel/turborepo#4706 <!-- Tobias Koppers - make
library code less verbose in stack traces -->
* vercel/turborepo#4705 <!-- Tobias Koppers -
improve error handling in update stream -->
* vercel/turborepo#4667 <!-- Caleb Webber - remove
box_syntax -->
* vercel/turborepo#4714 <!-- Tobias Koppers - chunk
hash need to include availability root -->
* vercel/turborepo#4709 <!-- Alex Kirszenberg -
Allow the dev server socket to be reused immediately -->
* vercel/turborepo#4716 <!-- Tobias Koppers - errors
lead to consistent exit code in issue detail -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Handle fatal errors in update stream, by sending an not found update
with issues.

---------

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Handle fatal errors in update stream, by sending an not found update
with issues.

---------

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Handle fatal errors in update stream, by sending an not found update
with issues.

---------

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants